Prevent TOML invalidation by pirates of T[elements...]
#39252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Jan 14, 2021
Sacha0
approved these changes
Jan 14, 2021
StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this.
timholy
force-pushed
the
teh/toml_invalidations
branch
from
904fa74
to
48061b4
Compare
|
Done. |
aviatesk
approved these changes
Jan 15, 2021
Sacha0
reviewed
Jan 15, 2021
| @@ -657,13 +657,20 @@ end | |||
| ######### | |||
|
|
|||
| function push!!(v::Vector, el) | |||
| # Since these types are typically non-inferrable, they are a big invalidation risk, | |||
ericphanson
reviewed
Jan 16, 2021
| # Since these types are typically non-inferrable, they are a big invalidation risk, | ||
| # and since it's used by the package-loading infrastructure the cost of invalidation | ||
| # is high. Therefore, this is written to reduce the "exposed surface area": e.g., rather | ||
| # than writing `T[el]` we write it as `push!(Vector{T}(undef, 1), el)` so that there |
There was a problem hiding this comment.
tiny nit, but push!(Vector{T}(undef, 1), el) should be push!(Vector{T}(undef, 0), el) or the version in the code, right?
KristofferC
pushed a commit
that referenced
this pull request
Jan 19, 2021
StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this. (cherry picked from commit 985dfa5)
KristofferC
pushed a commit
that referenced
this pull request
Feb 1, 2021
StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this. (cherry picked from commit 985dfa5)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…9252) StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…9252) StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
StaticArrays (perhaps among others) semi-pirates this method, although they've worked hard to make it pretty innocuous. Still, there are times when it invalidates the TOML-reading, so best to protect this. (cherry picked from commit 985dfa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticArrays (perhaps among others) semi-pirates this method,
although they've worked hard to make it pretty innocuous.
Still, there are times when it invalidates the TOML-reading,
so best to protect this.